Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Feb 21, 2022

I'd added myself as an approver here in 5cf5ba3 (#11752). This comment isn't structured metadata, but it makes it slightly less likely that folks ask me to review things like "I'm adding a new repository".

@openshift-ci openshift-ci bot requested review from hongkailiu and smg247 February 21, 2022 19:01
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2022
I'd added myself as an approver here in 5cf5ba3
(core-services/prow/02_config/generate-boskos: For spitting out lots
of names, 2020-10-08, openshift#11752).  This comment isn't structured
metadata, but it makes it slightly less likely that folks ask me to
review things like "I'm adding a new repository".
@wking wking force-pushed the comment-to-explain-wking-prow-config-ownership-scope branch from aa7ac65 to 534bc9f Compare February 23, 2022 09:32
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 23, 2022

@wking: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit c902aa4 into openshift:master Feb 23, 2022
@wking wking deleted the comment-to-explain-wking-prow-config-ownership-scope branch February 24, 2022 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants